Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): single partition publisher implementation #3225

Merged
merged 8 commits into from Nov 25, 2020

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 18, 2020

Implements the publisher for a single partition. A Bundler is used to batch messages.

singlePartitionPublisher is equivalent to PublisherImpl in the Pub/Sub Lite Java client library.

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Nov 18, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2020
Implements the publisher for a single partition.
@tmdiep tmdiep marked this pull request as ready for review November 18, 2020 05:00
@tmdiep tmdiep requested a review from a team as a code owner November 18, 2020 05:00
@tmdiep
Copy link
Contributor Author

tmdiep commented Nov 18, 2020

WANT_LGTM=@dpcollins-google
Other reviewers optional, but feel free to leave comments.

pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publisher.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publisher.go Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
Copy link

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but not actually approving. Going to leave for hongalex@ to provide golang approval (I have written ~2000 lines of golang in my life)

@tmdiep tmdiep changed the title feat(pubsublite): Single partition publisher feat(pubsublite): single partition publisher implementation Nov 24, 2020
pubsublite/internal/wire/publish_batcher.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_batcher_test.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_batcher.go Outdated Show resolved Hide resolved
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@tmdiep tmdiep merged commit 4982eeb into googleapis:master Nov 25, 2020
@tmdiep tmdiep deleted the single_publisher branch November 25, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants