Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): Single and multi partition subscribers #3221

Merged
merged 8 commits into from Nov 19, 2020

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 17, 2020

Implements:

  • subscriberStream: directly wraps the Subscribe bidi stream.
  • singlePartitionSubscriber: wraps the committer and subscriberStream.
  • multiPartitionSubscriber: receives messages from multiple fixed partitions.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Nov 17, 2020
@tmdiep tmdiep marked this pull request as ready for review November 17, 2020 08:27
@tmdiep tmdiep requested a review from a team as a code owner November 17, 2020 08:27
@tmdiep
Copy link
Contributor Author

tmdiep commented Nov 17, 2020

WANT_LGTM=@manuelmenzella-google
Other reviewers optional. Feel free to leave comments.

pubsublite/internal/wire/subscriber.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/subscriber.go Show resolved Hide resolved
@tmdiep tmdiep merged commit 299b803 into googleapis:master Nov 19, 2020
@tmdiep tmdiep deleted the subscriber1 branch November 19, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants