Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add support for PublicAccessPrevention #3203

Closed
shaffeeullah opened this issue Nov 12, 2020 · 0 comments · Fixed by #3608
Closed

storage: add support for PublicAccessPrevention #3203

shaffeeullah opened this issue Nov 12, 2020 · 0 comments · Fixed by #3608
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shaffeeullah
Copy link
Contributor

We need to add support for a new field publicAccessPrevention in the bucket IAM configuration for storage. Full details are available in this doc. This should include ability to create buckets with this field set, get the field, and set the field. We'd also like an integration test that verifies that the feature works as expected.

Please wait for approval from myself or @tritone before merging or releasing this change so we can coordinate around release dates.

Based on looking at the code, I think the field should go here:

type BucketAttrs struct {

@shaffeeullah shaffeeullah added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 12, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 12, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Nov 12, 2020
tritone added a commit to tritone/google-cloud-go that referenced this issue Jan 25, 2021
This is a new field in the IAM configuration for buckets.
Support viewing/setting via bucket attrs, and add an integration
test for the feature.

Closes googleapis#3203
tritone added a commit that referenced this issue Jun 28, 2021
This is a new field in the IAM configuration for buckets.
Support viewing/setting via bucket attrs, and add an integration
test for the feature.

Closes #3203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants