Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spannertest): support UPDATE DML #3201

Merged
merged 1 commit into from Nov 12, 2020
Merged

feat(spanner/spannertest): support UPDATE DML #3201

merged 1 commit into from Nov 12, 2020

Conversation

dsymonds
Copy link
Contributor

Fixes #3162.

@dsymonds dsymonds added the api: spanner Issues related to the Spanner API. label Nov 12, 2020
@dsymonds dsymonds requested review from skuruppu and a team as code owners November 12, 2020 02:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@dsymonds dsymonds mentioned this pull request Nov 12, 2020
Closed
olavloite
olavloite approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1dec6f6 into googleapis:master Nov 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2020
@dsymonds dsymonds deleted the spannertest-update-dml branch November 12, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/spansql: support for Update in parseDMLStmt
2 participants
@dsymonds @olavloite