feat(pubsublite): Committer implementation #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits desired offsets based on the ack prefix offset. Commits are batched.
product-auto-label
bot
added
the
api: pubsublite
google-cla
bot
added
the
cla: yes
tmdiep
added
the
do not merge
|
WANT_LGTM=@manuelmenzella-google Depends on a number of other PRs to be committed first, mainly #3143. Calling out potentially controversial behavior of the committer: when Stop() is called, it the stream is left open to process outstanding acks. For example, the user may call Subscriber.Stop() to stop receiving new messages from the server, and continue processing/acking all the outstanding messages. But if they never finish acking all those messages, the committer stream remains open. Perhaps we should have a timer to do a hard shutdown after N minutes? Or expose a Subscriber.Shutdown() to do the hard shutdown (but relies on the user to call this)? |
manuelmenzella-google
approved these changes
Nov 13, 2020
tmdiep
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits desired offsets based on the ack prefix offset. Commits are batched.