Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spansql): define structures and parse UPDATE DML statements #3192

Merged
merged 1 commit into from Nov 11, 2020
Merged

feat(spanner/spansql): define structures and parse UPDATE DML statements #3192

merged 1 commit into from Nov 11, 2020

Conversation

dsymonds
Copy link
Contributor

Updates #3162.

@dsymonds dsymonds requested a review from a team as a code owner November 10, 2020 22:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 10, 2020
olavloite
olavloite approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation does not seem to support setting a column to NULL. I'm happy with regarding that as a TODO, as this would probably already help people a lot.

spanner/spansql/parser.go Show resolved Hide resolved
spanner/spansql/sql_test.go Show resolved Hide resolved
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@dsymonds dsymonds changed the title spanner/spansql: define structures and parse UPDATE DML statements feat(spanner/spansql): define structures and parse UPDATE DML statements Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 23b6904 into googleapis:master Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@dsymonds dsymonds deleted the spansql-update-dml branch November 11, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsymonds @olavloite