feat(spanner): export ToSpannerError #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ToSpannerError method should be exported to allow users to create Spanner errors to use with unit tests. Currently, that was only possible by creating a struct directly and filling the deprecated Code field. That is however no longer recommended, as the code field might be removed in a future release. Fixes #3122
google-cla
bot
added
the
cla: yes
codyoss
changed the title
hengfengli
reviewed
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ToSpannerErrormethod should be exported to allow users to create Spanner errors to use with unit tests. Currently, that was only possible by creating a struct directly and filling the deprecatedCodefield. That is however no longer recommended, as theCodefield might be removed in a future release.Fixes #3122