Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: new method for declaring spanner.Error #3122

Closed
skdrums opened this issue Nov 2, 2020 · 1 comment · Fixed by #3133
Closed

spanner: new method for declaring spanner.Error #3122

skdrums opened this issue Nov 2, 2020 · 1 comment · Fixed by #3133
Assignees
@olavloite
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@skdrums
Copy link

skdrums commented Nov 2, 2020 •
edited

Is your feature request related to a problem? Please describe.
In spanner, Code field in Error struct is deprecated and spanner recommends using ErrCode method for extracting the err code.
But we don't have a method for declaring it(ex. NewError()). we can't declare spanner.Error struct without Error.Code field in unit tests.

Describe the solution you'd like

I want a new method for declaration of spanner.Error struct.
ex. cloud.google.com/go/spanner/errors.go

package spanner

import ...

type Error struct {
. . .
}

// something new below
func NewError(err error) *Error {
 . . .
}

Describe alternatives you've considered

spanner user can declare spanner.Error struct in unit tests without deprecated spanner.Error.Code field.
@skdrums skdrums added the triage me I really want to be triaged. label Nov 2, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 2, 2020
@skuruppu skuruppu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 2, 2020
@skuruppu skuruppu assigned olavloite and unassigned skuruppu Nov 2, 2020
olavloite added a commit that referenced this issue Nov 3, 2020
@olavloite
feat: export ToSpannerError
1d92133 
The ToSpannerError method should be exported to allow users to create
Spanner errors to use with unit tests. Currently, that was only possible
by creating a struct directly and filling the deprecated Code field. That
is however no longer recommended, as the code field might be removed in a
future release.

Fixes #3122
@olavloite olavloite mentioned this issue Nov 3, 2020
Merged
@skdrums
Copy link
Author

skdrums commented Nov 4, 2020

Thank you for dealing with this issue:)

olavloite added a commit that referenced this issue Nov 4, 2020
@olavloite
feat(spanner): export ToSpannerError (#3133)
b951d8b 
* feat: export ToSpannerError

The ToSpannerError method should be exported to allow users to create
Spanner errors to use with unit tests. Currently, that was only possible
by creating a struct directly and filling the deprecated Code field. That
is however no longer recommended, as the code field might be removed in a
future release.

Fixes #3122

* fix: use New instead of Newf
@apstndb apstndb mentioned this issue Nov 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(spanner): export ToSpannerError googleapis/google-cloud-go
3 participants
@skuruppu @olavloite @skdrums