New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsublite): Retryable stream wrapper #3068
Conversation
This is loosely based on https://github.com/googleapis/google-cloud-go/blob/master/pubsub/pullstream.go. An example of usage will be the publisher (not ready for review yet): I will consolidate unit tests for the publisher and retryableStream, as there is much overlap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be valuable to add some tests here to ensure no deadlocks/races.
Thanks Cody. Yes, definitely need tests! Since retryableStream needs a concrete client stream to operate on, there will be substantial overlap with [unit tests](https://github.com/tmdiep/google-cloud-go/blob/working/pubsublite/publisher_internal_test.go] for the upcoming publisher. |
Thanks everyone for reviewing. Merging.. |
This will be used to manage all of Pub/Sub Lite's bidi streaming RPCs: publish, subscribe, streaming cursor commit, partition assignment, etc.