Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): add opencensus tracing support #2942

Merged
merged 8 commits into from Feb 4, 2021

Conversation

AlisskaPie
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@AlisskaPie AlisskaPie marked this pull request as ready for review September 30, 2020 20:05
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Oct 1, 2020
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. @BenWhitehead could you take a look?

firestore/transaction.go Show resolved Hide resolved
firestore/transaction.go Show resolved Hide resolved
firestore/client.go Outdated Show resolved Hide resolved
@crwilcox crwilcox requested a review from a team as a code owner December 2, 2020 19:10
Copy link
Contributor Author

@AlisskaPie AlisskaPie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crwilcox Thank you!

firestore/transaction.go Show resolved Hide resolved
firestore/client.go Outdated Show resolved Hide resolved
@tritone
Copy link
Contributor

tritone commented Jan 23, 2021

@crwilcox could you take another look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants