Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): increase deferred key iter limit #2878

Merged
merged 3 commits into from Sep 17, 2020
Merged

fix(datastore): increase deferred key iter limit #2878

merged 3 commits into from Sep 17, 2020

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Sep 17, 2020

A customer was hitting the upper bound for iteration through
deferred keys, and the logic underlying the 100 iteration limit
was flawed. Based on internal discussions and what's happening
in other clients, it's fine to increase this value.

@tritone
fix(datastore): increase deferred key iter limit
ac72c70 
A customer was hitting the upper bound for iteration through
deferred keys, and the logic underlying the 100 iteration limit
was flawed. Based on internal discussions and what's happening
in other clients, it's fine to increase this value.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2020
@tritone
Copy link
Contributor Author

tritone commented Sep 17, 2020

cc @BenWhitehead

@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label Sep 17, 2020
codyoss
codyoss approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWhitehead
Copy link

Thanks for looking into this @tritone!

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Sep 17, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7f1057a into googleapis:master Sep 17, 2020
@tritone tritone deleted the ds-iter-fix branch September 21, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@tbpg tbpg Awaiting requested review from tbpg

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tritone @BenWhitehead @codyoss