Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub): add flush method to topic #2863

Merged
merged 10 commits into from May 24, 2021
Merged

feat(pubsub): add flush method to topic #2863

merged 10 commits into from May 24, 2021

Conversation

hongalex
Copy link
Member

To complement the FlushAndStop method, add a Flush method that flushes all publishes topics but does not stop the topic.

Closes #1831

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@hongalex hongalex changed the title Pubsub topic flush feat(pubsub): add flush method to topic Sep 15, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Sep 16, 2020
@hongalex hongalex requested review from a team as code owners April 1, 2021 22:24
codyoss
codyoss approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, but LGTM.

pubsub/topic.go Outdated Show resolved Hide resolved
pubsub/topic.go Show resolved Hide resolved
@hongalex hongalex merged commit 825ddd6 into googleapis:master May 24, 2021
@hongalex hongalex deleted the pubsub-topic-flush branch May 24, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: add flush feature to topic
2 participants
@hongalex @codyoss