Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiler): do not collect disabled profile types #2836

Merged
merged 10 commits into from Sep 12, 2020
Merged

fix(profiler): do not collect disabled profile types #2836

merged 10 commits into from Sep 12, 2020

Conversation

kalyanac
Copy link
Contributor

Fixes #2835

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2020
@kalyanac kalyanac requested a review from jqll September 10, 2020 16:36
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the Cloud Profiler API. label Sep 11, 2020
@kalyanac kalyanac marked this pull request as draft September 12, 2020 03:11
@kalyanac kalyanac marked this pull request as ready for review September 12, 2020 03:49
@kalyanac
Copy link
Contributor Author

I pushed a commit by mistake, reverted it now. Please merge once tests pass.

@kalyanac kalyanac merged commit faeb498 into googleapis:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

@jqll jqll jqll approved these changes

@codyoss codyoss Awaiting requested review from codyoss

@aalexand aalexand Awaiting requested review from aalexand

Assignees
No one assigned
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiler: Go agent should not collect disabled profile types
4 participants
@kalyanac @aalexand @tbpg @jqll