Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): start generating v1 #2700

Merged
merged 2 commits into from Aug 7, 2020

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Aug 7, 2020

No description provided.

@hongalex hongalex requested a review from codyoss August 7, 2020 00:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2020
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check in the config file and repo metadata file that gets updated when generating this.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hongalex hongalex merged commit d2e777f into googleapis:master Aug 7, 2020
tritone pushed a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
* feat(pubsublite): start generating v1

* add internal gen files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants