spanner: TestIntegration_BatchQuery failed

[flaky-bot]

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

---

commit: 891bf76
buildURL: Build Status, Sponge
status: failed

[flaky-bot]

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

---

commit: 891bf76
buildURL: Build Status, Sponge
status: passed

[olavloite]

@skuruppu These flaky failures are caused by UNAVAILABLE errors on CreateDatabase RPCs.

[skuruppu]

@olavloite, oh I see. Does that mean we could do a similar thing to what you proposed for Java where we add a retry loop for non-idempotent RPCs?

[skuruppu]

@olavloite if you can implement the same fix for Go as you did for Java, I think that would help.

[olavloite]

@skuruppu Yes, I'll have a look.

[olavloite]

Background info: CreateDatabase is non-idempotent and is therefore not automatically retried by the gapic client. We implemented custom retry logic for this and other non-idempotent RPCs for Java, and we'll do that for Go as well.

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: 3bcbd5d
buildURL: Build Status, Sponge
status: failed

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: 3bcbd5d
buildURL: Build Status, Sponge
status: failed

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: 3bcbd5d
buildURL: Build Status, Sponge
status: failed

[hengfengli]

This is related to googleapis/go-genproto#366, which has been fixed.

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: abe7c9a
buildURL: Build Status, Sponge
status: failed

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: abe7c9a
buildURL: Build Status, Sponge
status: failed

[hengfengli]

@olavloite This is caused by a nil pointer reference in a different test: TestClient_ReadWriteTransaction_BatchDMLAbortedHalfway. Do you have any idea about this?

[olavloite]

Yes, while fixing a flaky test case in https://code-review.googlesource.com/c/gocloud/+/56990 I forgot to commit one of the files. Kokoro gave the green light, even though the build panicked with the same error as here, so it was merged in. It was fixed shortly after in https://code-review.googlesource.com/c/gocloud/+/56991.

[hengfengli]

Thanks. I will close this then.