From c314f58bf81a45d41ec2deeedd9f2cee395859d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Knut=20Olav=20L=C3=B8ite?= Date: Wed, 2 Dec 2020 04:38:15 +0100 Subject: [PATCH] test(spanner): queries always return at least one partial result set (#3305) Queries will always return at least one partial result set containing the metadata of the query, even if the query does not return any rows. That was not taken into account in one of the test cases. Fixes #3295 Co-authored-by: skuruppu --- spanner/read_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/spanner/read_test.go b/spanner/read_test.go index 87f658960c2..5c1e74a1af5 100644 --- a/spanner/read_test.go +++ b/spanner/read_test.go @@ -929,6 +929,11 @@ func TestRsdBlockingStates(t *testing.T) { name: "unConnected -> queueingRetryable", sql: "SELECT t.key key, t.value value FROM t_mock t", stateHistory: []resumableStreamDecoderState{queueingRetryable}, + want: []*sppb.PartialResultSet{ + { + Metadata: kvMeta, + }, + }, }, { // unConnected->queueingRetryable->queueingRetryable @@ -1177,7 +1182,7 @@ func TestRsdBlockingStates(t *testing.T) { mutex.Lock() defer mutex.Unlock() if !testEqual(rs, test.want) { - t.Fatalf("received PartialResultSets: \n%v\n, want \n%v\n", rs, test.want) + t.Fatalf("%s: received PartialResultSets: \n%v\n, want \n%v\n", test.name, rs, test.want) } // Verify that resumableStreamDecoder's internal buffering is also // correct.