From 07004baf8ed8e1f12bce6ea7e0cb5a2a6c5b8bdf Mon Sep 17 00:00:00 2001 From: Simon Zeltser Date: Thu, 29 Oct 2020 07:16:02 -0700 Subject: [PATCH] chore: add api-logging codeowners (#3093) - Debranded logging and error reporting from "Stackdriver" - Added api-logging team to codeowners of logging and error reporting --- .github/CODEOWNERS | 3 ++- .github/blunderbuss.yml | 5 +++++ logging/README.md | 7 +++++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 6296d656ec8a..e1f8e6f1203a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -5,7 +5,8 @@ /bigquery/ @googleapis/api-bigquery /datastore/ @tritone /firestore/ @tritone -/logging/ @nicoleczhu /pubsub/ @googleapis/api-pubsub /spanner/ @skuruppu /storage/ @tritone +/errorreporting/ @googleapis/api-logging +/logging/ @googleapis/api-logging diff --git a/.github/blunderbuss.yml b/.github/blunderbuss.yml index cfec629c8cc7..85411bb53638 100644 --- a/.github/blunderbuss.yml +++ b/.github/blunderbuss.yml @@ -22,3 +22,8 @@ assign_issues_by: - 'api: spanner' to: - skuruppu +- labels: + - 'api: logging' + - 'api: clouderrorreporting' + to: + - nicolezhu diff --git a/logging/README.md b/logging/README.md index 242c7f14f7e7..6ebe9ce14309 100644 --- a/logging/README.md +++ b/logging/README.md @@ -9,17 +9,19 @@ First create a `logging.Client` to use throughout your application: [snip]:# (logging-1) + ```go ctx := context.Background() client, err := logging.NewClient(ctx, "my-project") if err != nil { - // TODO: Handle error. + // TODO: Handle error. } ``` Usually, you'll want to add log entries to a buffer to be periodically flushed (automatically and asynchronously) to the Cloud Logging service. [snip]:# (logging-2) + ```go logger := client.Logger("my-log") logger.Log(logging.Entry{Payload: "something happened!"}) @@ -27,9 +29,10 @@ logger.Log(logging.Entry{Payload: "something happened!"}) Close your client before your program exits, to flush any buffered log entries. [snip]:# (logging-3) + ```go err = client.Close() if err != nil { - // TODO: Handle error. + // TODO: Handle error. } ```