From 1d397aa8b41f8f980cba1d3dcc50f11e4d4f4ca0 Mon Sep 17 00:00:00 2001 From: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com> Date: Wed, 11 Nov 2020 14:48:11 -0500 Subject: [PATCH] fix(internal/godocfx): filter out test packages from other modules (#3197) Test packages don't have module set, so they aren't filtered out in the existing check. The order of packages isn't defined as far as I can tell. So, we may not know to skip a package when we first see it. --- internal/godocfx/parse.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/internal/godocfx/parse.go b/internal/godocfx/parse.go index b7ba6ea1667..52a5e8bc052 100644 --- a/internal/godocfx/parse.go +++ b/internal/godocfx/parse.go @@ -453,6 +453,17 @@ func loadPackages(glob, workingDir string) ([]pkgInfo, error) { result := []pkgInfo{} for _, pkgPath := range pkgNames { + // Check if pkgPath has prefix of skipped module. + skip := false + for skipModule := range skippedModules { + if strings.HasPrefix(pkgPath, skipModule) { + skip = true + break + } + } + if skip { + continue + } parsedFiles := []*ast.File{} fset := token.NewFileSet() for _, f := range pkgFiles[pkgPath] {