Skip to content

Commit

Permalink
fix(bigtable): fix #4338 by removing obsolete with block (#4353)
Browse files Browse the repository at this point in the history
  • Loading branch information
crwilcox committed Jun 30, 2021
1 parent c03b544 commit 1cf34b3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions bigtable/bigtable.go
Expand Up @@ -79,9 +79,7 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
option.WithGRPCConnectionPool(4),
// Set the max size to correspond to server-side limits.
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(1<<28), grpc.MaxCallRecvMsgSize(1<<28))),
// TODO(grpc/grpc-go#1388) using connection pool without WithBlock
// can cause RPCs to fail randomly. We can delete this after the issue is fixed.
option.WithGRPCDialOption(grpc.WithBlock()))
)
// Attempts direct access to spanner service over gRPC to improve throughput,
// whether the attempt is allowed is totally controlled by service owner.
o = append(o, internaloption.EnableDirectPath(true))
Expand Down

0 comments on commit 1cf34b3

Please sign in to comment.