Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GAPIC's BUILD.bazel files #14171

Closed
Tracked by #14108
dbolduc opened this issue May 8, 2024 · 1 comment
Closed
Tracked by #14108

Refactor GAPIC's BUILD.bazel files #14171

dbolduc opened this issue May 8, 2024 · 1 comment
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@dbolduc
Copy link
Member

dbolduc commented May 8, 2024

The BUILD.bazel files are fairly cookie cutter. They are generated as scaffolding, then maintained by hand. Making sweeping changes across them (e.g. defining public headers) can be cumbersome. Factoring out the definitions of these components will help reduce future maintenance costs.


Any library that is using our CMake helper can probably benefit from this helper. To get a list of libraries, I used:

grep -r "gapic_library" --include "CMakeLists.txt" -l | xargs dirname | sort

On first glance, I only see nuance in:

  • bigquery, iam: handwritten samples that need a dep on the mocks.
  • securitycenter: Not compatible on Windows, although @devbww tells me it will be compatible when we pick up Protobuf v27
@dbolduc
Copy link
Member Author

dbolduc commented May 15, 2024

Closing.

Only securitycenter remains. It is blocked externally on Protobuf v27. There is a v27-rc3 out now. I will just keep track of this in my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant