Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable checks that require code cleanup in .clang-tidy #14162

Open
4 tasks
alevenberg opened this issue May 8, 2024 · 0 comments
Open
4 tasks

Enable checks that require code cleanup in .clang-tidy #14162

alevenberg opened this issue May 8, 2024 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@alevenberg
Copy link
Member

alevenberg commented May 8, 2024

To enable it, remove it from the list of committed checks.

These checks are nice to have, but are current code does not conform to them. We need to cleanup the existing code first.

Checks to enable:

  • bugprone-unused-return-value
  • bugprone-inc-dec-in-condition
  • bugprone-unused-local-non-trivial-variable
  • misc-include-cleaner: too many true positives. We need to clean up the code, but we should do that over time, maybe per-directory, instead of blocking the adoption of Clang 17 until it is all fixed.
@alevenberg alevenberg added the type: cleanup An internal cleanup or hygiene concern. label May 8, 2024
@alevenberg alevenberg changed the title Enable -bugprone-unused-return-value in .clang-tidy Enable checks that require code cleanup in .clang-tidy May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant