Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libc++ hack #14152

Open
alevenberg opened this issue May 7, 2024 · 0 comments
Open

Remove libc++ hack #14152

alevenberg opened this issue May 7, 2024 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@alevenberg
Copy link
Member

Remove hack added in #14151.

During our Fedora 40 upgrades (#14076), we found lib C++ broke the ABI to enforce C++ compliance (llvm/llvm-project@d2cb198).

This means they removed a constructor for a std::future_error and the public constructor is only available in C++ 17 (https://en.cppreference.com/w/cpp/thread/future_error/future_error). When we upgrade to C++17, we can remove this hack.
@alevenberg alevenberg added the type: cleanup An internal cleanup or hygiene concern. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alevenberg