Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine best mechanism for setting service level metadata in generated libraries. #14000

Open
scotthart opened this issue Apr 16, 2024 · 0 comments
Labels
cpp: generator Issues related to the C++ micro-generator type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

With the added support for google.api.api_version, an optional annotation, the generator needs to emit code that sets this (when specified) in the generated metadata decorator. It currently sets it as part of *Metadata::SetMetadata, but this might not be the best place. One option would be to pass this value to the metadata helper functions as another parameter, similar to api_client_header. another option would be to create a collection of known at compile time metadata pairs and pass that to the metadata helper function.

@scotthart scotthart added type: cleanup An internal cleanup or hygiene concern. cpp: generator Issues related to the C++ micro-generator labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp: generator Issues related to the C++ micro-generator type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant