feat(storage): promote gRPC plugin to GA #13858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13858 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 2268 2269 +1
Lines 195905 195907 +2
=======================================
+ Hits 183475 183479 +4
+ Misses 12430 12428 -2 ☔ View full report in Codecov by Sentry. |
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
30707a6
to
1600127
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
3c9ac9b
to
9794f34
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
2dfe719
to
3784c79
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
3784c79
to
5fc679f
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
5fc679f
to
ab5d613
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
ab5d613
to
428653e
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
428653e
to
1ea9527
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
1ea9527
to
f7064e1
Compare
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
f7064e1
to
cfff5a6
Compare
Move the gRPC plugin functions out of the `google::cloud::storage_experimental` namespace and remove the `experimental-` prefix from the CMake and Bazel targets. I left shims in place for backwards compatibility. The `AsyncClient` remains in the `storage_experimental` namespace, it is fully functional, but we may change some APIs.
coryan
force-pushed
the
feat-storage-promote-gRPC-plugin-to-GA
branch
from
cfff5a6
to
f2d8f8c
Compare
|
I think it will take a while to make a decision here. I may take a few more cleanups out of this PR, but closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the gRPC plugin functions out of the
google::cloud::storage_experimentalnamespace and remove theexperimental-prefix from the CMake and Bazel targets. I left shims in place for backwards compatibility.The
AsyncClientremains in thestorage_experimentalnamespace, it is fully functional, but we may change some APIs.Fixes #13875. See #13857 for the future cleanups.
This change is