Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote the GCS+gRPC plugin to GA #13875

Open
coryan opened this issue Mar 28, 2024 · 0 comments
Open

Promote the GCS+gRPC plugin to GA #13875

coryan opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Member

coryan commented Mar 28, 2024

This change is more involved than I thought at first, so I am creating a bug. We want to declare GA for the GCS+gRPC plugin. This is basically one new public function, but we also want to:

  • The storage_grpc library is part of __ga_libraries__
  • The target names with CMake are google-cloud-cpp::storage_grpc and google-cloud-cpp::storage_grpc_mocks
  • The rule names with Bazel are //:storage_grpc and //:storage_grpc_mocks.
  • The target names and rules names with the experimental- prefix should be preserved for at least one release.
  • Manually setting GOOGLE_CLOUD_CPP_ENABLE_CTYPE_CORD_WORKAROUND is tedious, we should let CMake figure this out.
  • We need to make a number of small tweaks to the ci/ scripts and their support files. May be cleaner to make them as separate PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant