Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete tests in tests/ directory #382

Open
cjac opened this issue Apr 10, 2022 · 0 comments
Open

Incomplete tests in tests/ directory #382

cjac opened this issue Apr 10, 2022 · 0 comments
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@cjac
Copy link

cjac commented Apr 10, 2022

Implementation exists for a number of classes which are not exercised in test/

$ grep -rsil 'class KeyInfo' -e 'KeyInfo.*new' lib test
lib/googleauth/id_tokens/key_sources.rb
test/id_tokens/key_sources_test.rb

$ grep -rsil -e 'class WebUserAuthorizer' -e 'WebUserAuthorizer.*new' lib test
lib/googleauth/web_user_authorizer.rb

$ grep -rsil -e 'class UserAuthorizer' -e 'UserAuthorizer.*new' lib test
lib/googleauth/user_authorizer.rb

$ grep -rsil -e 'class DefaultCredentials' -e 'DefaultCredentials.*new' lib test
lib/googleauth/default_credentials.rb

$ grep -rsil 'ServiceAccountCredentials' lib/ test/
lib/googleauth/service_account.rb

$ grep -rsil 'ClientId' lib test
lib/googleauth/client_id.rb

$ grep -rsil 'GCECredentials' lib test
lib/googleauth/compute_engine.rb

$ grep -rsil 'IAMCredentials' lib test
lib/googleauth/iam.rb

Thanks for stopping by to let us know something could be better!

Sure thing!

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 11, 2022
@dazuma dazuma added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants