Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix crash when using a client credential without any paths or env_vars set #296

Merged
merged 1 commit into from Feb 3, 2021

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Feb 3, 2021

We have some test cases in ruby-docs-samples that use Credentials classes without ever setting paths or env_vars. (This is not a valid production case, but we do run into it in some of our tests in other repos.) It causes an exception because the recent change to "inherit" these values from superclasses, causes the field to default to nil rather than the empty array. Fixed. Also updated the yardocs to make this more clear.

@dazuma dazuma requested a review from a team as a code owner February 3, 2021 00:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2021
@dazuma dazuma merged commit c971c1a into googleapis:master Feb 3, 2021
@dazuma dazuma deleted the pr/lookup-fix branch February 28, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant