Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable self signed jwt for domain wide delegation #873

Merged
merged 2 commits into from Sep 28, 2021
Merged

fix: disable self signed jwt for domain wide delegation #873

merged 2 commits into from Sep 28, 2021

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Sep 23, 2021 •
edited

resolves b/200830305

Self signed JWT doesn't work for domain wide delegation, so we need to disable it in this case.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@arithmetic1728 arithmetic1728 marked this pull request as ready for review September 27, 2021 19:52
@arithmetic1728 arithmetic1728 requested review from silvolu and a team as code owners September 27, 2021 19:52
@arithmetic1728 arithmetic1728 merged commit 0cd15e2 into main Sep 28, 2021
@arithmetic1728 arithmetic1728 deleted the disable_jwt branch September 28, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvolu silvolu silvolu approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arithmetic1728 @silvolu