feat: Improve handling of clock skew #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eesheesh
commented
Sep 7, 2021
eesheesh
commented
- Allow up to 60 seconds of clock skew.
- Make the error messages actionable to people who don't know the internals of OAuth/JWTs.
eesheesh
requested review from
arithmetic1728,
silvolu and
a team
as code owners
google-cla
bot
added
the
cla: yes
eesheesh
changed the title
tseaver
approved these changes
Sep 7, 2021
tseaver
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
arithmetic1728
added
the
owlbot:run
arithmetic1728
approved these changes
Sep 7, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.