Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'testing/constraints-*.txt' not used #759

Closed
tseaver opened this issue May 25, 2021 · 0 comments · Fixed by #760
Closed

'testing/constraints-*.txt' not used #759

tseaver opened this issue May 25, 2021 · 0 comments · Fixed by #760
Assignees
@tseaver
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented May 25, 2021

From #757.

In noxfile.py, the constraints are not being used, which is why the one populated file, [testing/constraints-3.6.txt](https://github.com/googleapis/google-auth-library-python/blob/master/testing/constraints-3.6.txt) is in an invalid state (multiple entries for rsa`, maybe more issues).
@tseaver tseaver added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 25, 2021
@tseaver tseaver self-assigned this May 25, 2021
@tseaver tseaver mentioned this issue May 25, 2021
Closed
tseaver added a commit that referenced this issue May 25, 2021
@tseaver
fix: enforce constraints during unit tests
6ac6365 
Drop explicit pin / constraint on 'urllib3':  specific 'requests'
versions have very narrow pins, and ours is only likely to create
conflicts.

Bump the 'requests' lower bound to '2.20.0', the lowest version for
which our tests pass once constraints are being checked.

Closes #759
@tseaver tseaver mentioned this issue May 25, 2021
Merged
busunkim96 pushed a commit that referenced this issue May 25, 2021
@tseaver
fix: enforce constraints during unit tests (#760)
1a6496a 
Drop explicit pin / constraint on 'urllib3':  specific 'requests'
versions have very narrow pins, and ours is only likely to create
conflicts.

Bump the 'requests' lower bound to '2.20.0', the lowest version for
which our tests pass once constraints are being checked.

Closes #759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enforce constraints during unit tests googleapis/google-auth-library-python
1 participant
@tseaver