Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pyopenssl as extra dependency #697

Merged
merged 2 commits into from Feb 12, 2021
Merged

fix: add pyopenssl as extra dependency #697

merged 2 commits into from Feb 12, 2021

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Feb 12, 2021

fix #551

pyopenssl is only needed if mTLS feature is enabled (disabled by default). To enable the feature, GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable has to be set to "true". More details see https://google.aip.dev/auth/4114.

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner February 12, 2021 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2021
setup.py Outdated Show resolved Hide resolved
@arithmetic1728 arithmetic1728 merged commit aeab5d0 into master Feb 12, 2021
@arithmetic1728 arithmetic1728 deleted the sijun_dep branch February 12, 2021 19:57
@eviljeff
Copy link

Does this address #551? (If not, can some further detail be added/linked?)

@arithmetic1728
Copy link
Contributor Author

Does this address #551? (If not, can some further detail be added/linked?)

Yep.

azuwis added a commit to azuwis/nixpkgs that referenced this pull request Jul 4, 2022
pyopenssl is broken on aarch64-darwin NixOS#172397

It's in `extras_require` (optional), and only needed if mTLS feature is
enabled (disabled by default) googleapis/google-auth-library-python#697
azuwis added a commit to azuwis/nixpkgs that referenced this pull request Jul 4, 2022
Pyopenssl is in `extras_require` (optional), and only needed if mTLS feature is
enabled (disabled by default) googleapis/google-auth-library-python#697

This will also make google-auth available on aarch64-darwin since
pyopenssl is broken NixOS#172397
SuperSandro2000 pushed a commit to SuperSandro2000/nixpkgs that referenced this pull request Jul 4, 2022
Pyopenssl is in `extras_require` (optional), and only needed if mTLS feature is
enabled (disabled by default) googleapis/google-auth-library-python#697

This will also make google-auth available on aarch64-darwin since
pyopenssl is broken NixOS#172397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pyOpenSSL Dependency
3 participants