Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move async interfaces to public surface once integrated #613

Open
crwilcox opened this issue Sep 25, 2020 · 5 comments
Open

Move async interfaces to public surface once integrated #613

crwilcox opened this issue Sep 25, 2020 · 5 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

Since there aren't any packages using this yet, it has been put in as _internal surface in #612

Once this is being used, we should move to a public surface with this.

  • google.auth.transport._aiohttp_requests -> google.auth.transport.aiohttp_requests
  • google.auth._jwt_async -> google.auth.jwt_async
  • google.auth._credentials_async -> google.auth.credentials_async
  • google.oauth2._service_account_async -> google.oauth2.service_account_async
  • google.oauth2._credentials_async -> google.oauth2.credentials_async
  • google.oauth2._id_token_async -> google.oauth2.id_token_async

Also, google/auth/__init__.py should be updated with the following:

from google.auth._default_async import default_async
 
__all__ = ["default", "load_credentials_from_file", "default_async"]
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 26, 2020
@busunkim96 busunkim96 added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Sep 28, 2020
@timuram
Copy link

timuram commented Dec 2, 2020

Hi
Any progress on this?

@juzna
Copy link
Contributor

juzna commented Jul 24, 2023

Hi, we'd really like to use this :) Any new plans for when this can be done?

@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed type: process A process-related concern. May include testing, release, or the like. labels Mar 4, 2024
@parthea
Copy link
Contributor

parthea commented Mar 4, 2024

Bumping priority due to b/326291423

@kiraksi
Copy link

kiraksi commented Mar 5, 2024

I would also like to use this!

@clundin25
Copy link
Contributor

Before making this API GA, we need to determine if it the inheritance pattern is correct.

I think the async classes inheriting from sync classes causes a few technical issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

8 participants