fix: reduce refresh clock skew to 10 seconds #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Aug 6, 2020
busunkim96
added a commit
that referenced
this pull request
Dec 8, 2020
Clock skew was changed in #581
busunkim96
added a commit
that referenced
this pull request
Dec 8, 2020
Clock skew was changed in #581
arithmetic1728
added a commit
that referenced
this pull request
Sep 7, 2021
clock skew has to be less than 30 seconds, see #581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce clock skew from 5 minutes to 10 seconds, since metadata server token endpoint doesn't generate a new token until 30s before the expiration, it just returns the same token and the corresponding expires_in value. google-auth will keep calling token endpoint for around 4 minutes 30 seconds because of this.