feat: add non-None default timeout to AuthorizedSession.request() #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamut
added
the
type: feature request
googlebot
added
the
cla: yes
|
Well go figure, running the |
Merged
plamut
commented
Jan 23, 2020
plamut
commented
Jan 23, 2020
busunkim96
approved these changes
Jan 23, 2020
rsgowman
added a commit
to firebase/firebase-admin-python
that referenced
this pull request
Jan 29, 2020
The upstream behaviour has changed such that None is no longer the default: googleapis/google-auth-library-python#435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #434.
This PR adds a non-
Nonedefault timeout toAuthorizedSession.request()to prevent requests from hanging indefinitely in a default case.Should help with https://github.com/googleapis/google-cloud-python/issues/10182