Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default request timeout to something other than None #434

Closed
plamut opened this issue Jan 23, 2020 · 0 comments · Fixed by #435
Closed

Set the default request timeout to something other than None #434

plamut opened this issue Jan 23, 2020 · 0 comments · Fixed by #435
Assignees
@plamut
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link
Contributor

plamut commented Jan 23, 2020

The AuthorizedSession.requests() method does not specify a default timeout.

Since production code would almost always want to have some sort of a timeout, let's add one. The libraries that rely on google-auth, but do (yet) not specify a timeout themselves, would benefit from that.

Example: storage issue
@plamut plamut added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 23, 2020
@plamut plamut self-assigned this Jan 23, 2020
@plamut plamut mentioned this issue Jan 23, 2020
Merged
busunkim96 pushed a commit that referenced this issue Jan 23, 2020
@plamut @busunkim96
feat: add non-None default timeout to AuthorizedSession.request() (#435)
d274a3a 
Closes #434.

This PR adds a non-None default timeout to `AuthorizedSession.request()` to prevent requests from hanging indefinitely in a default case.

Should help with googleapis/google-cloud-python#10182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add non-None default timeout to AuthorizedSession.request() plamut/google-auth-library-python
1 participant
@plamut