feat: add timeout parameter to AuthorizedSession.request() #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Merged
5 tasks
plamut
force-pushed
the
add-timeout-param
branch
2 times, most recently
from
058e855
to
74ceefa
Compare
plamut
force-pushed
the
add-timeout-param
branch
from
74ceefa
to
94276e8
Compare
plamut
force-pushed
the
add-timeout-param
branch
from
94276e8
to
cc243e4
Compare
busunkim96
approved these changes
Dec 9, 2019
busunkim96
changed the title
busunkim96
added a commit
that referenced
this pull request
Dec 9, 2019
This reverts commit 381dd40.
busunkim96
added a commit
that referenced
this pull request
Dec 9, 2019
This was referenced Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396.
Still needs a few extra tests, but outlining the general idea here.cc: @tswast