Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unittest.mock instead of mock #1055

Closed
pgajdos opened this issue Jun 8, 2022 · 3 comments · May be fixed by #1361
Closed

use unittest.mock instead of mock #1055

pgajdos opened this issue Jun 8, 2022 · 3 comments · May be fixed by #1361

Comments

@pgajdos
Copy link

pgajdos commented Jun 8, 2022

Could you please consider to utilize unittest.mock instead of mock?

s/import mock/from unittest import mock/

should suffice.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 9, 2022
@sai-sunder-s
Copy link
Contributor

google-auth library supports older versions of python as well. So we are still using the backport of unittest.mock.

Please feel free to reopen the issue if this doesn't answer your question.

@sai-sunder-s sai-sunder-s removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 14, 2022
@clundin25 clundin25 mentioned this issue Jul 25, 2023
Open
clundin25 added a commit to clundin25/google-auth-library-python that referenced this issue Jul 25, 2023
@clundin25
chore: Use stdlib unittest.mock instead of separate mock library. Res…
9b26950 
…olves googleapis#1055
@dvzrv
Copy link

dvzrv commented Mar 4, 2024

Hi! 👋

We are trying to remove python-mock from the Arch Linux repositories finally. This project is unfortunately blocking us from doing so.

@dvzrv
Copy link

dvzrv commented Mar 4, 2024

This project only supports Python >= 3.7 so using unittest.mock should be the norm, as it has been included in Python since 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Migrate from mock to unittest.mock clundin25/google-auth-library-python
4 participants
@dvzrv @pgajdos @sai-sunder-s @yoshi-automation