Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenPayload missing locale #973

Closed
drocha87 opened this issue Jun 11, 2020 · 0 comments · Fixed by #974
Closed

TokenPayload missing locale #973

drocha87 opened this issue Jun 11, 2020 · 0 comments · Fixed by #974
Assignees
@JustinBeckwith
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@drocha87
Copy link

Environment details

  • OS: windows 10
  • Node.js version: v13.12.0
  • npm version: 6.14.4
  • googleapis version:
    "google-auth-library": "^6.0.1",
    "googleapis": "^52.1.0",

The payload returned by getPayload has a locale property, but the interface TokenPayload exported in loginticket.d.ts doesn't have this property defined.
@JustinBeckwith JustinBeckwith transferred this issue from googleapis/google-api-nodejs-client Jun 14, 2020
@JustinBeckwith JustinBeckwith added the type: question Request for information or clarification. Not an issue. label Jun 14, 2020
@JustinBeckwith JustinBeckwith mentioned this issue Jun 14, 2020
Merged
@JustinBeckwith JustinBeckwith added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. labels Jun 14, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 16, 2020
@JustinBeckwith
fix(types): add locale property to idtoken (#974)
ebf9bed 
Fixes #973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): add locale property to idtoken googleapis/google-auth-library-nodejs
3 participants
@JustinBeckwith @drocha87 @sofisl