Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing tsc error caused by @types/node update #965

Merged
merged 1 commit into from May 21, 2020

Conversation

alexander-fenster
Copy link
Member

The recent commit DefinitelyTyped/DefinitelyTyped@e910379 to @types/node makes tsc trigger "code unreachable" error. Fixing this with a workaround as suggested in DefinitelyTyped/DefinitelyTyped#44944.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #965 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
- Coverage   92.90%   92.88%   -0.03%     
==========================================
  Files          19       19              
  Lines        4017     4017              
  Branches      456      491      +35     
==========================================
- Hits         3732     3731       -1     
- Misses        285      286       +1     
Impacted Files Coverage Δ
src/auth/googleauth.ts 97.42% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a9133...a98d697. Read the comment docs.

@alexander-fenster alexander-fenster merged commit b94edb0 into master May 21, 2020
@alexander-fenster alexander-fenster deleted the false-as-boolean branch May 21, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants