feat: cache results of getEnv() #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
==========================================
+ Coverage 85.2% 85.37% +0.16%
==========================================
Files 17 17
Lines 960 964 +4
Branches 215 215
==========================================
+ Hits 818 823 +5
Misses 85 85
+ Partials 57 56 -1
Continue to review full report at Codecov.
|
src/auth/envDetect.ts
Outdated
| } | ||
|
|
||
| async function getEnvMemoized(): Promise<GCPEnv> { | ||
| let env: GCPEnv | undefined; |
There was a problem hiding this comment.
Maybe just let env = GCPEnv.NONE; and remove the last else?
alexander-fenster
approved these changes
Dec 23, 2019
JustinBeckwith
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failing tests caused by introducing caching to gcp-metadata.
Taking a page fro
gcp-metadata, this now also caches the promise returned bygetEnvrather than its value, such that multiple libraries instantiated at the same time will not result in multiple enqueued promises.