Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use quota_project_id field instead of quota_project #832

Merged
merged 7 commits into from Nov 25, 2019

Conversation

broady
Copy link
Contributor

@broady broady commented Nov 22, 2019

The spec changed from quota_project to quota_project_id.

@broady broady requested a review from bcoe November 22, 2019 22:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #832 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files          17       17           
  Lines         958      958           
  Branches      215      215           
=======================================
  Hits          816      816           
  Misses         85       85           
  Partials       57       57
Impacted Files Coverage Δ
src/auth/refreshclient.ts 97.22% <100%> (ø) ⬆️
src/auth/jwtclient.ts 88.63% <100%> (ø) ⬆️
src/auth/oauth2client.ts 83.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2327cc2...9c64f12. Read the comment docs.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@bcoe bcoe merged commit 8933966 into master Nov 25, 2019
@bcoe bcoe deleted the quota_project_id branch November 25, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants