fix: expand on x-goog-user-project to handle auth.getClient() #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This expands on the initial implementation of
x-goog-user-project
header population, such that headers are appropriately populated whenauth.getClient().getRequestHeaders()
is called, the initial approach only supportedauth.getRequestHeaders()
.Thanks to @JustinBeckwith for pointing out this code-path which would have bitten us.
Implementation Details
This implementation is closer to @broady's initial recommendation of having the logic in
UserRefreshClient
rather than my suggestion ofGoogleAuth
, however, I've moved the logic for header population intoOAuth2Client
, this approach seemed elegant because:OAuth2Client
already implementsgetRequestHeaders
(and several clients, likeUserRefreshClient
rely on its implementation.quota_project
across clients.