feat: set x-goog-user-project header, with quota_project from default credentials #829
Conversation
googlebot
added
the
cla: yes
src/auth/googleauth.ts
Outdated
| if (this.jsonContent && this.jsonContent.quota_project) { | ||
| headers = Object.assign({}, headers, { | ||
| 'x-goog-user-project': this.jsonContent.quota_project, | ||
| }); |
There was a problem hiding this comment.
A comment about why it's not the other way around, i.e.
Object.assign({}, ..., headers)
There was a problem hiding this comment.
If client.getRequestHeaders() always returns an object, the whole Object.assign can be removed and replaced with a simple assignment :)
There was a problem hiding this comment.
I tend to agree that headers should take precedence if set explicitly, I've updated the PR and added a comment.
There was a problem hiding this comment.
I've noticed a few bugs in our auth library in my time working on it, caused by passing an object by reference and than modifying the object, e.g., deleting a key.
I've been being defensive by creating shallow copies with Object.assign({}), something worth thinking about in API design would be starting to Object.freeze objects that we don't wish for users to modify, at which point it forces people to make copies, but you can pass the object around if you do not need to mutate it.
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=========================================
Coverage ? 84.93%
=========================================
Files ? 17
Lines ? 956
Branches ? 214
=========================================
Hits ? 812
Misses ? 86
Partials ? 58
Continue to review full report at Codecov.
|
If the
quota_projectparameter is set, kicks it along in the request headerx-goog-user-project.