fix: don't append x-goog-api-client multiple times #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
+ Coverage 84.54% 84.57% +0.03%
==========================================
Files 17 17
Lines 951 953 +2
Branches 211 213 +2
==========================================
+ Hits 804 806 +2
Misses 87 87
Partials 60 60
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because options are passed by reference and not copied, a user specifying their own headers in gax options resulted in
x-goog-api-clientheaders being appended multiple times.fixes #819