fix(deps): update to gcp-metadata and address envDetect performance issues #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
commented
Sep 17, 2019
| } else if (await isComputeEngine()) { | ||
| env = GCPEnv.COMPUTE_ENGINE; | ||
| if (await isKubernetesEngine()) { |
There was a problem hiding this comment.
we end up performing one more check for kubernetes, but we use the fast path gcpMetadata.isAvailable rather than the slow gcpMetadata.instance('attributes/cluster-name') for the initial check, correcting issues with @nodejs/logging performance.
bcoe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 17 17
Lines 952 952
Branches 211 211
=======================================
Hits 803 803
Misses 88 88
Partials 61 61
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in an updated version of
gcp-metadatawhich checks both IP and HOST; failing fast as soon as one of the endpoints fails to respond (this addresses issues with cloud run, vs., local environment).Since only
gcpMetadata.isAvailable()is currently fast pathed, this also performs a slight refactor on environment detection, we first detectisComputeEngine()hittingisAvailable, if we detect that we are in a compute engine environment, we next check if we're in kubernetes.This results in one additional check, but improves cold-start performance in non-GCP environments drastically.
TODO: confirm with @JustinBeckwith, @stephenplusplus, etc., that
gcpMetadata.isAvailable()is true for kubernetes.