Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix variable name in README.md #782

Merged
merged 1 commit into from Sep 5, 2019
Merged

fix(docs): fix variable name in README.md #782

merged 1 commit into from Sep 5, 2019

Conversation

JonasLaux
Copy link
Contributor

@JonasLaux JonasLaux commented Sep 5, 2019

fixed naming of variable

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

fixed naming of variable
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 5, 2019
@bcoe bcoe changed the title Update README.md fix(docs): fix variable name in README.md Sep 5, 2019
@bcoe
Copy link
Contributor

bcoe commented Sep 5, 2019

@JonasLaux thanks for the contribution 👍 could I bother you to sign the CLA?

@JonasLaux
Copy link
Contributor Author

Hey,
yes i already did it, after the PR

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 5, 2019
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2019
@JustinBeckwith JustinBeckwith merged commit d8c70b9 into googleapis:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants