feat: populate x-goog-api-client header for auth #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 84.26% 84.34% +0.08%
==========================================
Files 17 17
Lines 947 952 +5
Branches 210 211 +1
==========================================
+ Hits 798 803 +5
Misses 88 88
Partials 61 61
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 84.26% 84.34% +0.08%
==========================================
Files 17 17
Lines 947 952 +5
Branches 210 211 +1
==========================================
+ Hits 798 803 +5
Misses 88 88
Partials 61 61
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After various discussions, where I ultimately landed was on:
User-Agentfields as they stand, as I've been assured that they won't interfere with the newx-goog-api-clientheader field.x-goog-api-clientheader to the auth client itself, putting us in the position to track information about folks using it directly.