Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): expose ProjectIdCallback interface #753

Merged
merged 1 commit into from Jul 24, 2019
Merged

feat(types): expose ProjectIdCallback interface #753

merged 1 commit into from Jul 24, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 24, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2019
@bcoe bcoe requested a review from JustinBeckwith July 24, 2019 17:51
@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files          17       17           
  Lines         947      947           
  Branches      210      210           
=======================================
  Hits          798      798           
  Misses         88       88           
  Partials       61       61
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944e2aa...4a80038. Read the comment docs.

@bcoe bcoe merged commit 5577f0d into master Jul 24, 2019
@bcoe bcoe deleted the expose-project-id branch July 24, 2019 18:00
@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files          17       17           
  Lines         947      947           
  Branches      210      210           
=======================================
  Hits          798      798           
  Misses         88       88           
  Partials       61       61
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944e2aa...4a80038. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoe @JustinBeckwith @googlebot