Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only require fast-text-encoding when needed #740

Merged
merged 1 commit into from Jun 25, 2019
Merged

fix: only require fast-text-encoding when needed #740

merged 1 commit into from Jun 25, 2019

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2019
JustinBeckwith referenced this pull request Jun 25, 2019
@JustinBeckwith
fix: feature detection to check for browser (#738)
83a5ba5
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #740 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   84.51%   84.41%   -0.11%     
==========================================
  Files          17       17              
  Lines         943      943              
  Branches      210      210              
==========================================
- Hits          797      796       -1     
- Misses         86       87       +1     
  Partials       60       60
Impacted Files Coverage 螖
src/crypto/browser/crypto.ts 6.06% <0%> (-3.04%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 326ba7f...7aac1f8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 25, 2019 •
edited

Codecov Report

Merging #740 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   84.51%   84.41%   -0.11%     
==========================================
  Files          17       17              
  Lines         943      943              
  Branches      210      210              
==========================================
- Hits          797      796       -1     
- Misses         86       87       +1     
  Partials       60       60
Impacted Files Coverage 螖
src/crypto/browser/crypto.ts 6.06% <0%> (-3.04%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 326ba7f...7aac1f8. Read the comment docs.

bcoe
bcoe approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustinBeckwith JustinBeckwith merged commit 04fcd77 into master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustinBeckwith @bcoe @alexander-fenster @googlebot