New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make both crypto implementations support sign #727
Conversation
…h-library-nodejs into pad-base64-test-crypto
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 84.69% 84.37% -0.33%
==========================================
Files 18 18
Lines 941 947 +6
Branches 209 209
==========================================
+ Hits 797 799 +2
- Misses 84 88 +4
Partials 60 60
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 84.69% 84.37% -0.33%
==========================================
Files 18 18
Lines 941 947 +6
Branches 209 209
==========================================
+ Hits 797 799 +2
- Misses 84 88 +4
Partials 60 60
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp approval, looks reasonable to me.
We actually don't really need it for now since the JWT code uses
jws
/jwa
to sign the authentication token, but since I started digging into this, I just decided to make twocrypto
implementations be similar in case if we need it later.