Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make both crypto implementations support sign #727

Merged
merged 10 commits into from Jun 5, 2019
Merged

Conversation

alexander-fenster
Copy link
Member

We actually don't really need it for now since the JWT code uses jws/jwa to sign the authentication token, but since I started digging into this, I just decided to make two crypto implementations be similar in case if we need it later.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #727 into master will decrease coverage by 0.32%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   84.69%   84.37%   -0.33%     
==========================================
  Files          18       18              
  Lines         941      947       +6     
  Branches      209      209              
==========================================
+ Hits          797      799       +2     
- Misses         84       88       +4     
  Partials       60       60
Impacted Files Coverage Δ
src/crypto/crypto.ts 71.42% <ø> (ø) ⬆️
src/crypto/browser/crypto.ts 8.82% <0%> (-1.18%) ⬇️
src/auth/googleauth.ts 86.01% <100%> (-0.12%) ⬇️
src/crypto/node/crypto.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5b4d9...de990a5. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #727 into master will decrease coverage by 0.32%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   84.69%   84.37%   -0.33%     
==========================================
  Files          18       18              
  Lines         941      947       +6     
  Branches      209      209              
==========================================
+ Hits          797      799       +2     
- Misses         84       88       +4     
  Partials       60       60
Impacted Files Coverage Δ
src/crypto/crypto.ts 71.42% <ø> (ø) ⬆️
src/crypto/browser/crypto.ts 8.82% <0%> (-1.18%) ⬇️
src/auth/googleauth.ts 86.01% <100%> (-0.12%) ⬇️
src/crypto/node/crypto.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe53ad...abfacc5. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp approval, looks reasonable to me.

@alexander-fenster alexander-fenster merged commit e445fb3 into master Jun 5, 2019
@alexander-fenster alexander-fenster deleted the sign branch June 5, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants